You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement RepOrder methods for MFMA and WMMA layouts. Both layouts have row major rep layout. Also,
isTranspose flag in MFMA layout does not affect RepOrder, meaning RepOrder is row major in both cases.
Also, this commit changes kMajor to kMinor notation. For a long time, kMajor is mis-used to indicate K is the fastest changing dimension. If we follow the same convention of row-major, it actually means elements on the same row are contiguous in memory.
Thank you @oplavsic
Since you are here, can you also change kMajor to kMinor? For a long time, kMajor is mis-used to indicate K is the fastest changing dimension. If we follow the same convention of row-major, it actually means elements on the same row are contiguous in memory. So k-major means elements of the same k index are contiguous in memory, which is not what we mean here.
The reason will be displayed to describe this comment to others. Learn more.
LGTM @oplavsic Can you also include the fix of kmajor -> kminor in the PR title and description?
oplavsic
changed the title
[AMD] Implement RepOrder for AMD MMA layouts
[AMD] Implement RepOrder for AMD MMA layouts and change kMajor notation to kMinor
Nov 13, 2024
So k-major means elements of the same k index are contiguous in memory, which is not what we mean here.
I see your point, but perhaps kMajor is just ambiguous. The way I thought about this is "as you traverse the K dimension, it's contiguous". In the same way that rowMajor means that "as you traverse a row, it's contiguous". What about using kContig?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oplavsic
changed the title
Implement RepOrder methods for MFMA and WMMA layouts. Both layouts have row major rep layout. Also,
isTranspose flag in MFMA layout does not affect RepOrder, meaning RepOrder is row major in both cases.
Also, this commit changes kMajor to kMinor notation. For a long time, kMajor is mis-used to indicate K is the fastest changing dimension. If we follow the same convention of row-major, it actually means elements on the same row are contiguous in memory.